inspire-harvester: add more transformation rules #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
force-pushed
the
codex/implement-field-mappings-for-transform_entry-function
branch
from
dd20fcc to
8882b80
Compare
jrcastro2
commented
Jun 17, 2025
| if degree_type: | ||
| result["type"] = degree_type | ||
| if institutions: | ||
| uni = institutions[0].get("name") |
Contributor
Author
There was a problem hiding this comment.
are we okay with this? any ohter ideas?
Contributor
There was a problem hiding this comment.
no, I would fail if there are more values than 1
|
|
||
| pub_infos = self.inspire_metadata.get("publication_info", []) | ||
| if pub_infos: | ||
| journal_cf = self._transform_journal(pub_infos[0]) |
Contributor
Author
There was a problem hiding this comment.
there might be multple pub_infos ... is it okay to take the first one?
kpsherva
reviewed
Jun 19, 2025
Comment on lines
+144
to
+145
| if lang: | ||
| trans_title["lang"] = lang |
Contributor
There was a problem hiding this comment.
it would be a bit more readable if you assign all values, even if they default to None and clean the empty keys at the end, we will avoid nested if statements
kpsherva
reviewed
Jun 19, 2025
Comment on lines
+138
to
+151
| for translation in translations: | ||
| lang = translation.get("language") | ||
| title = translation.get("title") | ||
| subtitle = translation.get("subtitle") | ||
| if title: | ||
| trans_title = {"title": title, "type": {"id": "translated-title"}} | ||
| if lang: | ||
| trans_title["lang"] = lang | ||
| rdm_additional_titles.append(trans_title) | ||
| if subtitle: | ||
| sub = {"title": subtitle, "type": {"id": "subtitle"}} | ||
| if lang: | ||
| sub["lang"] = lang | ||
| rdm_additional_titles.append(sub) |
Contributor
There was a problem hiding this comment.
Suggested change
| for translation in translations: | |
| lang = translation.get("language") | |
| title = translation.get("title") | |
| subtitle = translation.get("subtitle") | |
| if title: | |
| trans_title = {"title": title, "type": {"id": "translated-title"}} | |
| if lang: | |
| trans_title["lang"] = lang | |
| rdm_additional_titles.append(trans_title) | |
| if subtitle: | |
| sub = {"title": subtitle, "type": {"id": "subtitle"}} | |
| if lang: | |
| sub["lang"] = lang | |
| rdm_additional_titles.append(sub) | |
| for translation in translations: | |
| lang = translation.get("language") | |
| title = translation.get("title") | |
| subtitle = translation.get("subtitle") | |
| type = None | |
| if title: | |
| type = "translated-title" | |
| elif subtitle: | |
| type = "subtitle" | |
| else: | |
| raise | |
| additional_title = {"title": title or subtitle, "type": {"id": "translated-title"}, "lang": lang} | |
| ... remove none keys.... | |
| rdm_additional_titles.append(additional title) |
not sure if it is more readable this way, so it is not a strong opinion,
kpsherva
reviewed
Jun 19, 2025
| if not value: | ||
| continue | ||
|
|
||
| if schema in ["PACS", "CERN LIBRARY"]: |
Contributor
There was a problem hiding this comment.
lets maybe leave a comment that it was agreed to drop these schemes.
Did you see maybe UDC schema in any of the records?
kpsherva
reviewed
Jun 19, 2025
| if journal_record := info.get("journal_record"): | ||
| related_identifiers.append( | ||
| { | ||
| "identifier": journal_record, |
Contributor
There was a problem hiding this comment.
this info about journal should also go to journal:journal custom field
kpsherva
reviewed
Jun 19, 2025
| related_identifiers.append( | ||
| { | ||
| "identifier": parent_rep, | ||
| "scheme": "cdsref", |
Contributor
There was a problem hiding this comment.
I think it was
Suggested change
| "scheme": "cdsref", | |
| "scheme": "cds_ref", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.