chore(cli): clean up OSC theme detection code

- Remove unused logger import from theme-system.ts - Update outdated
comment in terminal-color-detection.ts - Delete unused
terminal-input-guard.ts file

Author: brandonkachen

cli/src/utils/terminal-color-detection.ts

@@ -92,8 +92,8 @@ function buildOscQuery(oscCode: number): string {
  * 
  * IMPORTANT: This function reads from stdin because OSC responses come through
  * the PTY which appears on stdin. This means it MUST be run BEFORE any other
- * stdin listeners (like OpenTUI) are attached. The subprocess approach via
- * --internal-osc-detect flag ensures this.
+ * stdin listeners (like OpenTUI) are attached. OSC detection runs at the very
+ * start of main() in index.tsx, before OpenTUI is initialized.
  * 
  * @param ttyPath - Path to TTY for writing the query
  * @param query - The OSC query string to send
@@ -141,7 +141,7 @@ async function sendOscQuery(
         }
       }
 
-      // Pause stdin so the subprocess can exit cleanly
+      // Pause stdin so we leave it non-flowing before other listeners attach
       try {
         process.stdin.pause()
       } catch {

cli/src/utils/terminal-input-guard.ts

@@ -2,8 +2,6 @@ import { existsSync, readFileSync, readdirSync, statSync, watch } from 'fs'
 import { homedir } from 'os'
 import { dirname, join } from 'path'
 
-import { logger } from './logger'
-
 import type { MarkdownPalette } from './markdown-renderer'
 import type {
   ChatTheme,

cli/src/utils/theme-system.ts

@@ -1,15 +1,7 @@
 import { clientEnvSchema, clientProcessEnv } from './env-schema'
 
-// Only log environment in non-production, and not during OSC detection
-// Check process.argv since it's more reliable than env vars in spawned processes
-const isOscDetect =
-  typeof process !== 'undefined' &&
-  Array.isArray(process.argv) &&
-  process.argv.some(arg => arg.includes('--internal-osc-detect'))
-if (
-  process.env.NEXT_PUBLIC_CB_ENVIRONMENT !== 'prod' &&
-  !isOscDetect
-) {
+// Only log environment in non-production
+if (process.env.NEXT_PUBLIC_CB_ENVIRONMENT !== 'prod') {
   console.log('Using environment:', process.env.NEXT_PUBLIC_CB_ENVIRONMENT)
 }
 

common/src/env.ts

@@ -2,16 +2,8 @@
 import { serverEnvSchema, serverProcessEnv } from './env-schema'
 
 
-// Only log environment in non-production, and not during OSC detection
-// Check process.argv since it's more reliable than env vars in spawned processes
-const isOscDetect =
-  typeof process !== 'undefined' &&
-  Array.isArray(process.argv) &&
-  process.argv.some(arg => arg.includes('--internal-osc-detect'))
-if (
-  process.env.NEXT_PUBLIC_CB_ENVIRONMENT !== 'prod' &&
-  !isOscDetect
-) {
+// Only log environment in non-production
+if (process.env.NEXT_PUBLIC_CB_ENVIRONMENT !== 'prod') {
   console.log('Using environment:', process.env.NEXT_PUBLIC_CB_ENVIRONMENT)
 }