Gha config #2
Closed
Gha config #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed .NET 6 from the target frameworks in all project files and updated the README to reflect the new minimum supported version (.NET 8). This change streamlines support and testing for newer .NET versions.
Introduces a GitHub Actions workflow that restores dependencies, builds, and tests the .NET project on Windows using .NET 10.0.x. This ensures automated validation of code on every push.
There was a problem hiding this comment.
Pull request overview
This PR removes .NET 6.0 support from all DocSharp projects and adds a GitHub Actions CI workflow. The changes drop support for .NET 6.0 while maintaining support for .NET 8, 9, 10, and .NET Framework 4.6.2.
- Removes
net6.0andnet6.0-windowsfrom all project target frameworks - Updates README documentation to reflect .NET 6 is no longer supported
- Introduces a new CI workflow for building and testing
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DocSharp.SystemDrawing/DocSharp.SystemDrawing.csproj | Removes net6.0-windows from target frameworks |
| src/DocSharp.Markdown/DocSharp.Markdown.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.ImageSharp/DocSharp.ImageSharp.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.Docx/DocSharp.Docx.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.Common/DocSharp.Common.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.Binary/DocSharp.Binary.Xls/DocSharp.Binary.Xls.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.Binary/DocSharp.Binary.Ppt/DocSharp.Binary.Ppt.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.Binary/DocSharp.Binary.Doc/DocSharp.Binary.Doc.csproj | Removes net6.0 from target frameworks |
| src/DocSharp.Binary/DocSharp.Binary.Common/DocSharp.Binary.Common.csproj | Removes net6.0 from target frameworks |
| src/.github/workflows/ci.yml | Adds new CI workflow for restore, build, and test operations |
| README.md | Updates documentation to reflect .NET 6 is no longer supported |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/.github/workflows/ci.yml
Outdated
Comment on lines
1
to
26
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Restore, Build, Test, Pack | ||
| runs-on: windows-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v3 | ||
| with: | ||
| dotnet-version: '10.0.x' | ||
|
|
||
| - name: Restore | ||
| run: dotnet restore | ||
|
|
||
| - name: Build | ||
| run: dotnet build --configuration Release --no-restore --nologo | ||
|
|
||
| - name: Test | ||
| run: dotnet test --configuration Release --no-build --nologo No newline at end of file |
There was a problem hiding this comment.
The GitHub Actions workflow file is placed in an incorrect location. Workflow files should be located at .github/workflows/ci.yml (at the repository root), not src/.github/workflows/ci.yml. GitHub Actions will not discover or execute workflows in the src/.github/ directory.
Suggested change
| name: CI | |
| on: | |
| push: | |
| jobs: | |
| build: | |
| name: Restore, Build, Test, Pack | |
| runs-on: windows-latest | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Setup .NET | |
| uses: actions/setup-dotnet@v3 | |
| with: | |
| dotnet-version: '10.0.x' | |
| - name: Restore | |
| run: dotnet restore | |
| - name: Build | |
| run: dotnet build --configuration Release --no-restore --nologo | |
| - name: Test | |
| run: dotnet test --configuration Release --no-build --nologo | |
| # This file is intentionally not a GitHub Actions workflow. | |
| # | |
| # Active workflows must be placed under: | |
| # .github/workflows/ci.yml | |
| # | |
| # If you want to use the CI pipeline, create or move the workflow | |
| # definition to `.github/workflows/ci.yml` at the repository root. | |
| # | |
| # Example (previous content that was incorrectly placed here): | |
| # | |
| # name: CI | |
| # | |
| # on: | |
| # push: | |
| # | |
| # jobs: | |
| # build: | |
| # name: Restore, Build, Test, Pack | |
| # runs-on: windows-latest | |
| # steps: | |
| # - name: Checkout | |
| # uses: actions/checkout@v4 | |
| # | |
| # - name: Setup .NET | |
| # uses: actions/setup-dotnet@v3 | |
| # with: | |
| # dotnet-version: '10.0.x' | |
| # | |
| # - name: Restore | |
| # run: dotnet restore | |
| # | |
| # - name: Build | |
| # run: dotnet build --configuration Release --no-restore --nologo | |
| # | |
| # - name: Test | |
| # run: dotnet test --configuration Release --no-build --nologo |
Comment on lines
19
to
25
| - name: Restore | ||
| run: dotnet restore | ||
|
|
||
| - name: Build | ||
| run: dotnet build --configuration Release --no-restore --nologo | ||
|
|
||
| - name: Test |
There was a problem hiding this comment.
The dotnet commands need to specify the correct working directory or solution path. The solution file is located at src/DocSharp.sln, but the workflow runs commands without specifying this path. Either add working-directory: src to each step, or update the commands to reference the solution file explicitly (e.g., dotnet restore src/DocSharp.sln).
Suggested change
| - name: Restore | |
| run: dotnet restore | |
| - name: Build | |
| run: dotnet build --configuration Release --no-restore --nologo | |
| - name: Test | |
| - name: Restore | |
| working-directory: src | |
| run: dotnet restore | |
| - name: Build | |
| working-directory: src | |
| run: dotnet build --configuration Release --no-restore --nologo | |
| - name: Test | |
| working-directory: src |
Moved ci.yml to the root .github/workflows directory and updated restore, build, and test steps to explicitly reference src/DocSharp.sln. This ensures the correct solution is targeted during CI runs.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.