Skip to content

Fix ArtifactPathInfo to reject non-standard paths #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruhan1 merged 1 commit into from
Dec 12, 2025
Merged

Fix ArtifactPathInfo to reject non-standard paths #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions identities/src/main/java/org/commonjava/atlas/maven/ident/util/ArtifactPathInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ public static ArtifactPathInfo parse( final String path )
.replace( '/', '.' );
final String a = matcher.group( ARTIFACT_ID_GROUP );
final String v = matcher.group( VERSION_GROUP );
final String f = matcher.group( FILE_GROUP );

// Validate that the filename follows standard Maven layout: {artifactId}-{version}-...
// This prevents mis-parsing paths that match the regex pattern but don't follow Maven conventions
String expectedPrefix = a + "-" + v;
if ( !f.startsWith( expectedPrefix ) || f.contains( "/" ) )
{
return null;
}

String c = "";
String t = null;
Expand Down Expand Up @@ -131,8 +140,6 @@ public static ArtifactPathInfo parse( final String path )
c = left.substring( 0, leftLen - extLen );
}

final String f = matcher.group( FILE_GROUP );

if ( checksumType != null && CHECKSUM_TYPES.contains( checksumType ) )
{
t = t + checksumType;
Expand Down
9 changes: 9 additions & 0 deletions identities/src/test/java/org/commonjava/atlas/maven/ident/util/ArtifactPathInfoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,15 @@ public void matchCompoundExtTypes2(){
assertThat( info.getType(), equalTo( "a.b.c" ) );
}

@Test
public void testNonStandardRpmPathReturnsNull()
{
// RPM path where filename doesn't follow Maven naming convention
String path = "/org/jboss/pnc/rpm/org/hibernate/search/hibernate-search-integrationtest-jakarta-jb-eap-8.0-rhel-9/6.2.2.Final/eap8-hibernate-search-6.2.2-1.Final.1.el8.src.rpm";
ArtifactPathInfo info = ArtifactPathInfo.parse( path );
assertThat( info, equalTo( null ) );
}

@Test
public void testChecksumTypes()
{
Expand Down