Skip to content

Conversation

@yma955
Copy link
Member

@yma955 yma955 commented Nov 19, 2025

No description provided.

@coveralls
Copy link

coveralls commented Nov 19, 2025

Pull Request Test Coverage Report for Build 19809247037

Details

  • 0 of 52 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 65.443%

Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/cmd/init.py 0 2 0.0%
charon/cmd/cmd_merge.py 0 50 0.0%
Totals Coverage Status
Change from base Build 19783559479: -1.0%
Covered Lines: 2318
Relevant Lines: 3542

💛 - Coveralls

Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM except a simple param hint.

@yma955
Copy link
Member Author

yma955 commented Nov 27, 2025

@ligangty Do you know why the rpm-build checks were stuck? I see it also happened on your #361, not sure how to rebuild, it seems unable to merge.

@yma955
Copy link
Member Author

yma955 commented Nov 28, 2025

@ligangty I tried to rerun, failed due to Coveralls 422 problem, unable to merge from my side.

@ligangty
Copy link
Member

ligangty commented Dec 1, 2025

@yma955 that's weird. I've tried a PR #363 but it does not meet this issue. Can you rebase and have a try?

@yma955
Copy link
Member Author

yma955 commented Dec 1, 2025

@ligangty pass after rebase, thanks!

@yma955 yma955 merged commit dbf1785 into Commonjava:main Dec 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants