-
Notifications
You must be signed in to change notification settings - Fork 565
feat: add Kilo Code configurator for AutoConfig support #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new editor configurator class, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds KiloCodeConfigurator to enable automatic MCP configuration for Kilo Code VS Code extension users. Closes CoplayDev#250
cf2078b to
6168df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
MCPForUnity/Editor/Clients/Configurators/KiloCodeConfigurator.cs (3)
10-17: Platform-specific config paths look consistent with stated targets; consider non-default VS Code installsThe Windows/macOS/Linux paths align with the documented Kilo Code locations and the PR objectives. If you expect users on VS Code Insiders, OSS builds (e.g.,
Code - OSS/VSCodium), or portable installs, you may eventually want to extend this to alternateCoderoots or surface a way to override the path in the UI.
16-16: Double-check thatIsVsCodeLayout = truematches Kilo’s JSON structure, not just storage location
IsVsCodeLayoutis documented onMcpClientas “config file follows VS Code layout (env object at root)”, which is about the JSON shape. Kilo’smcp_settings.jsonunderglobalStoragemay have its own schema; if it doesn’t mirror the standard VS Code layout with anenvobject at the root, this flag could cause JsonFileMcpConfigurator to read/write the file incorrectly. Please confirm the actual Kilo file structure and flip this tofalse(or adjust the configurator) if the layout differs.
20-27: Installation steps are clear; consider tightening language around themcpServersobjectThe steps are concise and actionable. To reduce ambiguity, you might explicitly state that users should create the
mcpServersobject if it doesn’t already exist and that they’re editing the samemcp_settings.jsonfile pointed to by the auto-config path, to avoid confusion with other MCP-related settings in VS Code/Kilo.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MCPForUnity/Editor/Clients/Configurators/KiloCodeConfigurator.cs(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
MCPForUnity/Editor/Clients/Configurators/KiloCodeConfigurator.cs (1)
MCPForUnity/Editor/Models/McpClient.cs (1)
McpClient(5-55)
Summary
KiloCodeConfiguratorto enable automatic MCP configuration for Kilo Code VS Code extension usersIsVsCodeLayout = trueas Kilo Code stores settings in VS Code's globalStorageConfig Paths
%APPDATA%/Code/User/globalStorage/kilocode.kilo-code/settings/mcp_settings.json~/Library/Application Support/Code/User/globalStorage/kilocode.kilo-code/settings/mcp_settings.json~/.config/Code/User/globalStorage/kilocode.kilo-code/settings/mcp_settings.jsonTest Plan
Closes #250
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.