Added flag for disabling HLSL intrinsics #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR description is empty, please add some valid description |
…hlsl-intrinsics` flag is set
| // Also removed: compress, decompress, /Gch (child effect), /Gpp (partial precision) | ||
| // /Op - no support for preshaders. | ||
|
|
||
| def devsh_disable_hlsl_intrinsics : Flag<["-"], "devsh-disable-hlsl-intrinsics">, Group<spirv_Group>, Flags<[CoreOption, DriverOption]>, |
There was a problem hiding this comment.
we could call it fvk- instead of devsh- to keep with the convention
Comment on lines
+28
to
+38
| extern std::optional<bool> disableHLSLIntrinsicsGlobalVariableBecauseIDontCare; | ||
|
|
||
| inline bool shouldDisableHLSLIntrinsics() | ||
| { | ||
| assert(disableHLSLIntrinsicsGlobalVariableBecauseIDontCare.has_value()); | ||
|
|
||
| if (!disableHLSLIntrinsicsGlobalVariableBecauseIDontCare.has_value()) | ||
| exit(-1); | ||
|
|
||
| return disableHLSLIntrinsicsGlobalVariableBecauseIDontCare.value(); | ||
| } |
There was a problem hiding this comment.
hide the global var (they mess with DLL delay loads), make the function non-inline and export like the hlsl::Check functions.
There was a problem hiding this comment.
none of the other SemaHLSL things seem to work via global vars!
Comment on lines
+5224
to
+5227
| "WorldToObject", | ||
| "WorldToObject3x4", | ||
| "WorldToObject4x3" | ||
| }; |
There was a problem hiding this comment.
a bunch of these are builtin input or output variables, shouldn't be allowed
| StringRef nameIdentifier, | ||
| size_t argumentCount) { | ||
| // TODO: only check if the flag "devsh-disable-hlsl-intrinsics" is enabled | ||
| if (shouldDisableHLSLIntrinsics() && !checkIfIntrinsicIsAllowed(nameIdentifier)) |
There was a problem hiding this comment.
do you need a standalone shouldDisableHLSLIntrinsics ? you could slap it into checkIfIntrinsicIsAllowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.