-
Notifications
You must be signed in to change notification settings - Fork 7
test: Add example services as a submodule #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 41 41
Lines 2565 2565
=======================================
Hits 2425 2425
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
07ef19b to
cc1abb2
Compare
cc1abb2 to
bc265d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't like having submodule`s for test but if this is the approach that we are taking then it should be atleast consistent among the athena repo system test (dodal,etc) and a ADR added to python copier template to make sure that it is documented that we are going to use submodules for system test so people can find a consistent way of running system test locally.
Also is there no way that this can be done inside the same vscode session rather than having a different terminal outside the devcontainer. This looked relevant
|
I am not hugely in love with submodules in general, but the previous set of instructions was getting silly and was only going to get more complicated over time. I really do feel that we need to keep the process for spinning up a dummy environment relatively easy and simple so developers can just do it rather than spend 10 minutes faffing around before they can do so, especially as it is not just for system tests but for playing around with a local blueapi server. Now that there are no dummy devices. Having to run outside of the devcontainer is really annoying but from talking to @DiamondJoseph and @gilesknap I don't think they're confident that podman will ever support it enough for us to trust it (they can correct me if I'm wrong though). |
ZohebShaikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as a starting point
I feel we have had this conversation before (more than once?) and that perhaps your use case here has issues. But in general docker compose based developer containers will work fully at DLS if you do the following setup https://epics-containers.github.io/main/how-to/compose-quickstart.html#diamond-light-source-workstation |
|
I was going to approve (sans one nit, it's spelt "associated"), I've just been looking at docker-in-docker, which may support our Ubuntu base images soon to see if we can get an even simpler workflow soon |
Add example services as a submodule and include it in the system tests docker compose file, rewrite the system test docs to make use of this. The system tests will now be easier to run and debug locally, since this automates a lot of the setup and tear down process.
ee7604a to
55ffed5
Compare
Add example services as a submodule and include it in the system tests docker compose file, rewrite the system test docs to make use of this.
The system tests will now be easier to run and debug locally, since this automates a lot of the setup and tear down process.