Skip to content

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Dec 12, 2025

If a callback raises an exception, it shouldn't prevent other callbacks
receiving the same event. It should also not raise the exception at the
call site that published the event.

@tpoliaw tpoliaw requested a review from a team as a code owner December 12, 2025 15:52
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.75%. Comparing base (18489bd) to head (73206be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   94.74%   94.75%           
=======================================
  Files          42       42           
  Lines        2741     2746    +5     
=======================================
+ Hits         2597     2602    +5     
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

If a callback raises an exception, it shouldn't prevent other callbacks
receiving the same event. It should also not raise the exception at the
call site that published the event.
@tpoliaw tpoliaw force-pushed the failsafe-event-handling branch from 6eda306 to 73206be Compare December 12, 2025 16:43
@tpoliaw tpoliaw changed the title Ignore (but log) errors from event stream callbacks fix: Handle errors from event stream callbacks Dec 12, 2025
@tpoliaw
Copy link
Contributor Author

tpoliaw commented Dec 12, 2025

The main symptom of this was that if a scan failed due to eg a stomp connection error, even if it reconnected, any subsequent scans would fail as the unsubscribe the tiled writer callback would never be called and tiled would return 409 conflict errors when two tiled writers tried to write the same events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants