-
Notifications
You must be signed in to change notification settings - Fork 1
Remove space from 'alt=' tag value. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤣 just came here to do exactly the same |
| fs.writeFileSync(fileName, svgCode); | ||
|
|
||
| let alt = `alt=" "`; | ||
| let alt = `alt=""`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'd do better in many cases to put the tex in alt!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and if the tex is a single character, it's really bad practice to replace it with a image!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'd do better in many cases to put the tex in alt!
But it might not be easy to determine which are the "many cases" (though I agree a single easily pronounceable character would be one such case), and it would be a bit inconsistent to have some of them with the TeX in the alt, and some of them not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example where tex in alt would be worse than '' in alt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but aside from accessibility, using generated images in place of inline math was what I did 29 years ago. And I certainly didn't render inline "A + Bx" as an image!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legacy formats (EPUB2, MOBI) probably won't validate but they're pretty awful anyway. I don't think the HTML5 or EPUB3 should have any problems, but if they do, it shouldn't be hard to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ppmath is used, images could be embedded for ebookmaker to use in epub2, delete for modern formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a sample with mathml for me, I can see if it's trivial or hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I.ve only recently become aware of this because I hadn't set up the notifications.
@eshellman I think it is important to use an image ( or other math component) even for single letters because the html font is not under our control so could look quite different to the same letter in a math expression. The arxiv looks interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@70ray If the typeface is really that important, you have a very good case for font embedding -
I suspect it may have been to avoid ebookmaker warnings, but this is undesirable, it ignores a valid issue.