Lower Android minSdk to 19 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- merged.yaml: Run tests (check) before publishing to Maven Central - released.yaml: Skip release creation if tag already exists - review.yaml: Remove redundant Gradle tasks (assemble, check already in build)
- Split review.yaml: Ubuntu for JVM/JS/WASM, macOS for Apple targets only - Add Konan cache to avoid re-downloading Kotlin/Native toolchains - Use macos-14 (M1) runners for faster Apple builds - Enable Gradle parallel builds and caching
- Remove redundant gradle/actions/setup-gradle (setup-java cache is sufficient) - Remove setup-chrome from merged.yaml (not needed for publishing) - Remove publishToMavenLocal from review (not needed for PR testing) - Add --no-build-cache for clean CI builds
Remove gradle/actions/setup-gradle which hangs during build scan upload
Add cleanup step to kill crashpad_handler processes that prevent the emulator from shutting down cleanly. This is a known issue with reactivecircus/android-emulator-runner (see issue #385).
- Change minSdk from 21 to 19 in build.gradle.kts - Add tools:overrideLibrary to test manifest for test dependencies that require API 21+ (tests still run on API 21+ devices) - Update CI to test on API 19 emulator
After successfully publishing to Maven Central, automatically:
- Get the version from Gradle
- Create and push a git tag (v{version})
- Create a GitHub release using the PR title and body
After successfully publishing to Maven Central, automatically:
- Get the version from Gradle
- Create and push a git tag (v{version})
- Create a GitHub release with PR title and link to PR for details
The getNextVersion function stored in project.extra was not being invoked, only converted to string which gave the function signature instead of the actual version number. This caused Maven artifacts to be published with incorrect names like: com.ditchoom-buffer-fun Setup_gradle.getNextVersion... Now properly casts and invokes the function to get the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Android minSdk
minSdkfrom 21 to 19tools:overrideLibraryfor test dependencies that require API 21+Auto-release on merge
./gradlew -q nextVersion)v{version})permissions: contents: writeto allow tag creation and release publishingFix version resolution bug
project.extra.get("getNextVersion")was returning the function signature instead of invoking the functioncom.ditchoom-buffer-fun Setup_gradle.getNextVersion...instead ofcom.ditchoom-buffer-1.4.4(project.extra["getNextVersion"] as (Boolean) -> Any)(!isRunningOnGithub)Test plan
./gradlew -q nextVersionoutputs correct version (1.4.4)