Fix release tag version mismatch and add skip-release mechanism #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version was being calculated after publishing, causing it to fetch the just-published version from Maven Central and increment it again. Now the version is calculated BEFORE publishing and reused for tagging.
- Add check-release job that runs before macos build - Skip release if PR has 'skip-release' label - Auto-detect non-code changes (.github/*, *.md, .gitignore, etc.) - Only proceed with release when actual code files are changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
check-releasejob to skip releases for non-code changesskip-releaselabel and automatic detection of non-code filesChanges
Version calculation fix: Version is now calculated once before any publishing step and reused for tagging, ensuring the tag matches the published version
Skip-release mechanism:
skip-releaselabel to any PR.github/*,*.md,.gitignore, etc.)Test plan
skip-releaselabel to a PR and verify no release is created