REC-195: recommend -store=file when keyring is not available #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the login and import commands, test if we can load a token from the keyring before doing anything. If the keyring is not available, print a message that recommends -store=file. Previously, we could go through the whole login flow then fail to store the token. This was frustrating for the user since it wasn't clear what to do next (keyring errors are obscure), and once they figure it out, then have to go through the login flow again.
rogerhu
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the login and import commands, test if we can load a token from
the keyring before doing anything. If the keyring is not available,
print a message that recommends -store=file.
Previously, we could go through the whole login flow then fail to
store the token. This was frustrating for the user since it wasn't
clear what to do next (keyring errors are obscure), and once they
figure it out, then have to go through the login flow again.