Skip to content

Conversation

@laszlocsomor
Copy link
Contributor

No description provided.

@laszlocsomor laszlocsomor requested a review from anfelbar June 10, 2025 15:09
@laszlocsomor laszlocsomor requested review from Yannic and jayconrod June 10, 2025 15:13
Copy link
Member

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please build a test release before merging to make sure the release pipeline is green

@jayconrod
Copy link
Contributor

The repo is configured to require checks on the old fleet. I think we can drop that requirement, but it will require dropping the fleet commit ID from the workflows here and dropping the commit ID from the required names in prod Terraform.

@laszlocsomor
Copy link
Contributor Author

The repo is configured to require checks on the old fleet.

What exactly do you mean?

I think we can drop that requirement, but it will require dropping the fleet commit ID from the workflows here and dropping the commit ID from the required names in prod Terraform.

I'm not sure what you're talking about. The only places I'm aware of where we reference CI fleet IDs are in GHA yamls, and I'm updating those in PRs like this one; prod's PR is merged already.

@laszlocsomor
Copy link
Contributor Author

Please build a test release before merging to make sure the release pipeline is green

Done, it's green: https://github.com/EngFlow/auth/actions/runs/15579728706/job/43871936365

@laszlocsomor
Copy link
Contributor Author

The repo is configured to require checks on the old fleet.

What exactly do you mean?

I think we can drop that requirement, but it will require dropping the fleet commit ID from the workflows here and dropping the commit ID from the required names in prod Terraform.

I'm not sure what you're talking about. The only places I'm aware of where we reference CI fleet IDs are in GHA yamls, and I'm updating those in PRs like this one; prod's PR is merged already.

Oh, I see now what you mean. That's the required steps that hung, with dd17e52a1f04529abb97003e8093d356739980d7 in their name. Lemme see if I can fix that.

@laszlocsomor
Copy link
Contributor Author

I've sent you both a PR to fix this.

Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@laszlocsomor laszlocsomor enabled auto-merge (squash) June 12, 2025 10:06
@laszlocsomor laszlocsomor merged commit 9ddbdfb into main Jun 12, 2025
5 checks passed
@laszlocsomor laszlocsomor deleted the laszlo-ci-4 branch June 12, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants