engflow_auth: add --insecure flag to "login" #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set, then server TLS check is disabled. Can be used for testing local clusters with self-signed certificates.
laszlocsomor
force-pushed
the
laszlo-tls
branch
from
0694996 to
b5fc012
Compare
jayconrod
approved these changes
Sep 24, 2025
Contributor
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Seems reasonable. As I understand, the behavior here is consistent with grpcurl, which has a separate -plaintext flag to disable TLS (I don't think we need that though).
It would be nice to have a test, but for a debugging feature, it seems like too much work to mock up a local server with insecure TLS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set, then disable server TLS validation. Can be used for testing.