-
Notifications
You must be signed in to change notification settings - Fork 443
report_converter: add support for ruff json input #4520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@melven, Thanks for the development, it's great to have a report-converter for ruff. |
Hi @bruntib I rebased onto the current master, let's see if everything works! |
|
Ok, this still fails but I don't really understand why. I tried to make the ruff test very similar to the pylint test. |
|
@melven Thanks for the rebase. Also, a required test is failing. We could merge this PR when it's fixed. Thank you! |
|
Sorry @bruntib This was a problem with an absolute path in the report file from ruff. I replaced it with a relative path for testing. |
|
Hi @bruntib Now the unit test succeeds. There is one further problem with the GUI but I don't understand the error message or why this is related to my changes... |
gulyasgergely902
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work overall with a minor "issue". Even with that I approve the change.
| @@ -0,0 +1,3 @@ | |||
| # copied from pylint, could | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment in unnecessary here. Please remove.
Add support for the json output format of the ruff python checker. Also works for fortitude which is based on ruff (https://github.com/PlasmaFAIR/fortitude)