feat: add default rotating log dir #328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type
[x] feat
[ ] fix
[x] docs
[ ] refactor
[ ] perf
[ ] test
[ ] chore
Description
Adds a default rotating log file so users automatically get persisted logs while still seeing real-time terminal output. Also documents the new log directory and environment overrides. Solves the problem reported in Discord where users couldn’t find logs without manually redirecting stdout.
Key Changes
Extend logging_config to create a rotating file handler in logs/parallax.log, configurable via env vars.
Keep stdout logging so existing UX stays intact.
Document default log location and overrides in README.md.
Related Issues
Closes #N/A
Checklist
[x] I have performed a self-review of my own code.
[x] I have added/updated tests that prove my fix or feature works (manual logging verification + pre-commit run --all-files).
[x] I have updated the documentation (if necessary).
[x] My code follows the project's style guidelines.