Skip to content

Conversation

@BenBrock
Copy link
Contributor

Fixing a few minor warnings as well as an error that seems to be popping up with the latest version of Bikeshed.

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

Automated Review URLs

@BenBrock
Copy link
Contributor Author

My local build was failing with the following error:

(venv) bbrock@hrkulkar-mobl3:~/src/binsparse-specification$ bikeshed spec spec/latest/index.bs
FATAL ERROR: Unknown Group 'GraphBLAS'. See docs for recognized Group values.

Apparently the most recent version of Bikeshed checks that the Group field is a recognized W3C or WHATWG group. As far as I can tell this field is not strictly necessary (it doesn't show up in the document), so I've removed it.

There also appears to be a way to manually define a group in the spec, so that would be the only other option.

@BenBrock BenBrock requested a review from jim22k February 20, 2025 18:22
@BenBrock
Copy link
Contributor Author

The repo rules appear to require at least one review to merge a PR, so I've requested a review from @jim22k.

@BenBrock BenBrock merged commit 5e06f39 into main Mar 19, 2025
1 check passed
@BenBrock BenBrock deleted the brock/fix-compilation-errors branch March 19, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants