Skip to content

Conversation

@tvolk131
Copy link
Contributor

@tvolk131 tvolk131 commented Sep 8, 2025

Bump the iced crate forward from late February 2025 to late April 2025. This requires a handful of changes, listed below. Each item in the list describes the change required in this PR, as well as the iced commit which requires the change.

Copilot AI review requested due to automatic review settings September 8, 2025 00:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the iced GUI framework from commit 940a079 to 8ba993a, advancing from late February 2025 to late April 2025. The update includes breaking changes that require API adaptations and type updates.

  • Update function signatures to use u32 instead of u16 for size parameters
  • Adapt application initialization API to use default state constructor and separate title method
  • Update overlay methods to include viewport parameter and manual palette type conversions

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
harbor-ui/Cargo.toml Updates iced dependency to newer commit revision
harbor-ui/src/main.rs Adapts application initialization API with default state and title method
harbor-ui/src/components/styles.rs Changes text size parameters from u16 to u32
harbor-ui/src/components/util.rs Updates palette color conversions to use manual constructors
harbor-ui/src/components/toast.rs Adds viewport parameter to overlay method signature
harbor-ui/src/components/indicator.rs Adds viewport parameter to overlay method signature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant