-
Notifications
You must be signed in to change notification settings - Fork 30
Scanner object considering multiple coils #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d84cb1e to
be1d62b
Compare
…dd a getprperty to the Scanner.limits.symbol values.
…mpact] and another small changes
…sens for RFCoilSensDefinedAtPhantomPositions
|
The branch works on my side to generate and reconstruct SMS sequence. Can you merge it at some point ? A missing feature will be have have standard 8/16/32 coils that are close to something real ? Or at least to share in the doc a good snippets to generate them |
…MRIPlots, (keep existing compat)
…MRIBase, (keep existing compat)
|
In my own testing this has worked nicely for a noncartesian sim. Would love to see fully incorporated. Cool development. |
|
Can I help on this PR ? :) |
|
Hi @aTrotier, yeah help with this PR would be great, as @Stockless is not working on it anymore. Can you let me know if you need collaborator access to modify it? I can add you. |
|
Do you have an idea what remains to be done 😅 I tested this PR a few months ago and it was working for multicoil and then to be able to perform a sense reconstruction. Maybe I can start to write an example to show what is missing. I think a helper function to write a coherent coil sensitivity map will be great |
If I remember correctly,
I think so. There is a few things here that might be useful https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/master/MRISimulation/src/CoilSensitivities.jl. In general we just need a function for the ith coil evaluated at positions x,y,z. Let me finish #612 first, that will change how some things work, and I will ping here again. |
|
Never worked on GPU programming but it might be the opportunity to learn
something.
…------------------------------------------------------------
TROTIER Aurélien
31 allée de la Biotte
33470 Gujan-Mestras
06.09.12.61.61
***@***.***
Le mer. 19 nov. 2025, 01:25, Carlos Castillo Passi ***@***.***>
a écrit :
*cncastillo* left a comment (JuliaHealth/KomaMRI.jl#548)
<#548 (comment)>
Do you have an idea what remains to be done 😅
If I remember correctly,
- GPU implementations were not finished yet.
- Complex coil sensitivities haven't been tested.
- Add some kind of test, like case without coils = case with coils
with sens = 1.
I think a helper function to write a coherent coil sensitivity map will be
great
I think so. There is a few things here that might be useful
https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/master/MRISimulation/src/CoilSensitivities.jl.
In general we just need a function for the ith coil evaluated at positions
x,y,z.
Let me finish #612 <#612>
first, that will change how some things work, and I will ping here again.
—
Reply to this email directly, view it on GitHub
<#548 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5P7OYA3TRT2KQIN6SIZPD35O2HXAVCNFSM6AAAAABZBRVIRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNJQGAYTQNJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Generation of a flexible and extensible Scanner object, to controll Hardware Limits, Gradient Behaviour, RF behaviour and magnetic field inhomegeneities.
Based in the pull request #454 and solving the issue #150 , this PR decouple the coils definition from the Phantom structure.
Clone this branch to test it using Julia Pkg: