Pass Discrete Sequence to GPU

[mcgrathcm]

In preparation for higher order sequences, this adds:

• Discrete sequences adapted and passed directly to GPU kernels
• Spatial gradient Bz term moved to its own helper function
• AbstractDiscreteSequence type added to allow dispatch when higher order sequences are added

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (b5c63a9) to head (2035faa).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   90.14%   90.09%   -0.06%     
==========================================
  Files          57       58       +1     
  Lines        3228     3230       +2     
==========================================
  Hits         2910     2910              
- Misses        318      320       +2     

Flag	Coverage Δ
base	88.92% <100.00%> (-0.17%)	⬇️
core	89.77% <100.00%> (+0.03%)	⬆️
files	94.05% <ø> (ø)
komamri	88.21% <ø> (ø)
plots	90.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl	100.00% <ø> (ø)
...IBase/src/datatypes/simulation/DiscreteSequence.jl	93.10% <100.00%> (-6.90%)	⬇️
KomaMRICore/src/KomaMRICore.jl	100.00% <ø> (ø)
KomaMRICore/src/simulation/Functors.jl	77.27% <ø> (ø)
...re/src/simulation/SimMethods/Bloch/cpu/BlochCPU.jl	100.00% <100.00%> (ø)
...re/src/simulation/SimMethods/Bloch/gpu/BlochGPU.jl	100.00% <ø> (ø)
...e/src/simulation/SimMethods/BlochDict/BlochDict.jl	85.18% <ø> (ø)
...c/simulation/SimMethods/BlochSimple/BlochSimple.jl	100.00% <ø> (ø)
KomaMRICore/src/simulation/SimulatorCore.jl	94.96% <ø> (ø)
KomaMRICore/src/simulation/SpatialEncoding.jl	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

KomaMRI Benchmarks

Benchmark suite	Current: 2035faa	Previous: b5c63a9	Ratio
MRI Lab/Bloch/CPU/2 thread(s)	365549150.5 ns	340960290 ns	1.07
MRI Lab/Bloch/CPU/4 thread(s)	284430115 ns	272489189 ns	1.04
MRI Lab/Bloch/CPU/8 thread(s)	260188629 ns	212102146.5 ns	1.23
MRI Lab/Bloch/CPU/1 thread(s)	565921915 ns	553123722 ns	1.02
MRI Lab/Bloch/GPU/CUDA	20263918 ns	21705981 ns	0.93
MRI Lab/Bloch/GPU/oneAPI	77678338 ns	79470326.5 ns	0.98
MRI Lab/Bloch/GPU/Metal	103679834 ns	95738917 ns	1.08
MRI Lab/Bloch/GPU/AMDGPU	26217619 ns	26055313 ns	1.01
Slice Selection 3D/Bloch/CPU/2 thread(s)	1622368544 ns	1588926486.5 ns	1.02
Slice Selection 3D/Bloch/CPU/4 thread(s)	902336276 ns	886294756.5 ns	1.02
Slice Selection 3D/Bloch/CPU/8 thread(s)	590207573.5 ns	561392306 ns	1.05
Slice Selection 3D/Bloch/CPU/1 thread(s)	3098118101 ns	3027587378 ns	1.02
Slice Selection 3D/Bloch/GPU/CUDA	31261767.5 ns	32637155 ns	0.96
Slice Selection 3D/Bloch/GPU/oneAPI	127028296.5 ns	124598595.5 ns	1.02
Slice Selection 3D/Bloch/GPU/Metal	113151145.5 ns	112846167 ns	1.00
Slice Selection 3D/Bloch/GPU/AMDGPU	34108195 ns	34082841 ns	1.00

This comment was automatically generated by workflow using github-action-benchmark.

[cncastillo]

The macos fails are due to actions/runner-images#13341.

[cncastillo]

Compare benchmarks with #653.

Update: macos cache problem fixed.

[cncastillo]

Looks very good, no significant performance regressions, but some of them could be explained by some of the suggestions below.