Download and install custom target JSONs automatically #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhql
force-pushed
the
custom_target_installer
branch
from
33faa23 to
1b54fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of
cargo-ledgerto always check whether thenanos,nanox,nanospluscustom target files from the Rust SDK are present in the rustup toolchain (therustc --print sysrootfolder). If they are not present,cargo-ledgerwill usecurlto get them from the SDK's master branch.After that, the targets are available to
cargofrom anywhere, with no need to point to a specific folder or use an environment variable, as was previously advised.This works thanks to rust-lang/rust#83800