compute,sql: remove dataflow shutdown duration introspection #34609
+89
−306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `mz_dataflow_shutdown_duration_histogram` introspection relations, as well as the supporting compute logging code. Since we've replaced shutdown tokens with `drop_dataflow`, dataflow shutdown is now instant, so this histogram doesn't provide any value now. It also didn't provide much value before, afaict, since nobody was looking at the data.
teskje
force-pushed
the
remove-dataflow-shutdown-duration
branch
from
a50a2b6 to
b3c0a9f
Compare
antiguru
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
mz_dataflow_shutdown_duration_histogramintrospection relations, as well as the supporting compute logging code.Since we've replaced shutdown tokens with
drop_dataflow, dataflow shutdown is now instant, so this histogram doesn't provide any value now. It also didn't provide much value before, afaict, since nobody was looking at the data.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.