[18.0][MIG] attachment_preview: Migration to 18.0 #552

ByteMeAsap · 2025-07-15T05:46:42Z

No description provided.

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

ivs-cetmix · 2025-12-19T22:34:37Z

@ByteMeAsap thank you for your contribution! Please squash the last two commits. Also please squash all the administrative commits with the [UPD] tag if you feel comfortable to do this.

[FIX] Lint [FIX] lint and flake [ADD] tests [ADD] tests [ADD] tests [ADD] Tests [ADD] Package python-magic [ADD] Tests [FIX] Lint

[REM] Old files [ADD] Magic to travis file [FIX] Nagivation refresh widget

Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/sl/

Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/tr/

…_attachment_preview

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/

Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/es/

Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/

Increased code coverage Changed layout of attachment_preview buttons Updates

ByteMeAsap · 2025-12-22T04:42:48Z

@ByteMeAsap thank you for your contribution! Please squash the last two commits. Also please squash all the administrative commits with the [UPD] tag if you feel comfortable to do this.
Done !!

tendil

@ByteMeAsap thank you for your contribution!
Please check my comments

tendil · 2025-12-24T07:45:31Z

attachment_preview/readme/CREDITS.md

@@ -0,0 +1,3 @@
+## Addon icon
+
+- courtesy of <http://commons.wikimedia.org/wiki/Crystal_Clear>


Remove references in CREDITS.md of past financed migrations by other companies.
wiki/Migration-to-version-18.0

tendil · 2025-12-24T07:46:47Z

attachment_preview/__manifest__.py

        ],
        "web.assets_frontend": [],
        "web.assets_tests": [],
        "web.qunit_suite_tests": [],


remove all empty lines

tendil · 2025-12-24T07:47:35Z

attachment_preview/models/ir_attachment.py

                self.env[model].with_context(bin_size=True).browse(ids_to_browse)
            ):
-                result[this.id] = False
+                # result[this.id] = False


remove unused code

tendil · 2025-12-24T07:50:25Z

attachment_preview/models/ir_attachment.py

-                if model == self._name and binary_field == "datas" and this.store_fname:
+                if (
+                    model == self._name and binary_field == "datas" and this.store_fname
+                ):  # pragma: no cover


we deliberately do not test this execution path? (# pragma: no cover)

tendil · 2025-12-24T07:56:03Z

attachment_preview/models/ir_attachment.py

+    _inherit = "ir.attachment"
+
+    @api.model
+    def get_binary_extension(self, model, ids, binary_field, filename_field=None):


all methods must have a clear dockstring in the standard format, please add

@tendil this is a migration PR, so the code stays as is

Aldeigja

@ByteMeAsap I'm not sure if this is a migration issue, but it seems that preview is currently not working for LibreOffice files.
Tested on version 14, it works there.

hbrunn and others added 15 commits July 3, 2025 17:42

[ADD] preliminary port of attachment_preview

2ead898

[IMP] have titles work everywhere

8379e03

[FIX] don't depend on document, the relevant code still lives in web

e3ce9fc

[ADD] translations

9224f52

[UPD] use viewerJS 0.5.4, incorporate new suported file types

0a31de8

[FIX] readme 8.0 style

659a484

Add OCA as author of OCA addons

7e3ed8c

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

fix travis (flake8)

197dc3c

Slovene translations added

d846ea0

[UPD] use viewerjs 0.5.7

6622bfc

Translations and templates sync

5d73bc0

[UPD] prefix versions with 8.0

a743216

[MIG] Make modules uninstallable

5a69211

[MIG] Rename manifest files

989e557

remove obsolete .pot files [ci skip]

463a2b5

ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch 15 times, most recently from 5a9e1bc to 4675660 Compare July 15, 2025 07:22

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025

tarteo and others added 24 commits December 22, 2025 10:04

[MIG] attachment_preview: Migration to 11.0

e2f1482

[FIX] Lint [FIX] lint and flake [ADD] tests [ADD] tests [ADD] tests [ADD] Tests [ADD] Package python-magic [ADD] Tests [FIX] Lint

[FIX] Robustness when attachment not present

8c62754

[IMP] attachment_preview: Split screen

2fb664d

[FIX] pylint/javascript-lint

339a461

[MIG] attachment_preview: Migration to 12.0

ced0c21

[REM] Old files [ADD] Magic to travis file [FIX] Nagivation refresh widget

Translated using Weblate (Slovenian)

33a6f42

Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/sl/

fix the visibility of the preview area

5830c99

attachment_preview 12.0.1.0.1

ec11470

Added translation using Weblate (Portuguese (Brazil))

ce5f32b

[FIX] attachment_preview: start needs to return a promise

caf63aa

[UPD] hbrunn's mail address

574d93e

attachment_preview 12.0.1.0.2

6a6cb21

Added translation using Weblate (Turkish)

9e95bed

Translated using Weblate (Turkish)

9026a1f

Currently translated at 100.0% (2 of 2 strings) Translation: knowledge-12.0/knowledge-12.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-attachment_preview/tr/

[IMP] attachment_preview: black, isort, prettier

05c8c60

[MIG] attachment_preview: Migration to 15.0

3175ce3

[MIG] attachment_preview: Migration to 15.0

f578ff0

[IMP] attachment_preview: fix _onPreviewAttachment and remove class o…

f6fc8da

…_attachment_preview

Update translation files

1ce81c4

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/

Translated using Weblate (Spanish)

2a74a6d

Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/es/

Translated using Weblate (Italian)

3bb24e2

Currently translated at 100.0% (4 of 4 strings) Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/it/

Update translation files

4f0bf1e

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-15.0/knowledge-15.0-attachment_preview Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-attachment_preview/

[IMP] attachment_preview: pre-commit auto fixes

ba7e2f5

[MIG] attachment_preview: Migration to 18.0

52934ee

Increased code coverage Changed layout of attachment_preview buttons Updates

ByteMeAsap force-pushed the 18.0-mig-attachment_preview branch from 8470908 to 52934ee Compare December 22, 2025 04:34

tendil suggested changes Dec 24, 2025

View reviewed changes

Aldeigja reviewed Dec 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] attachment_preview: Migration to 18.0 #552

[18.0][MIG] attachment_preview: Migration to 18.0 #552

Uh oh!

ByteMeAsap commented Jul 15, 2025

Uh oh!

ivs-cetmix commented Dec 19, 2025

Uh oh!

ByteMeAsap commented Dec 22, 2025

Uh oh!

tendil left a comment

Uh oh!

tendil Dec 24, 2025

Uh oh!

tendil Dec 24, 2025

Uh oh!

tendil Dec 24, 2025

Uh oh!

tendil Dec 24, 2025

Uh oh!

tendil Dec 24, 2025

Uh oh!

ivs-cetmix Dec 24, 2025

Uh oh!

Aldeigja left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		@@ -0,0 +1,3 @@
		## Addon icon

		- courtesy of <http://commons.wikimedia.org/wiki/Crystal_Clear>

Uh oh!

[18.0][MIG] attachment_preview: Migration to 18.0 #552

Are you sure you want to change the base?

[18.0][MIG] attachment_preview: Migration to 18.0 #552

Uh oh!

Conversation

ByteMeAsap commented Jul 15, 2025

Uh oh!

ivs-cetmix commented Dec 19, 2025

Uh oh!

ByteMeAsap commented Dec 22, 2025

Uh oh!

tendil left a comment

Choose a reason for hiding this comment

Uh oh!

tendil Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

tendil Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

tendil Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

tendil Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

tendil Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

ivs-cetmix Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Aldeigja left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants