Skip to content

Conversation

@Romathi
Copy link

@Romathi Romathi commented May 3, 2025

Description

This PR improves how maintainer avatars are rendered in the generated README table.

Current behavior

When a maintainer does not have a custom GitHub avatar, their image appears larger than others. This creates a visual inconsistency that affects readability and aesthetics.

Desired behavior after this PR

All maintainer avatars are rendered at a fixed size (32x32px) using HTML tags with a border-radius: 50% style to enforce a modern, consistent round shape.

This ensures a cleaner and more polished appearance for the table, regardless of whether the user has a custom avatar or not.

@sbidoul
Copy link
Member

sbidoul commented May 10, 2025

Thanks, good idea! Can you fix the test by updating tests/test_repo/README.md.expected ?

@sbidoul
Copy link
Member

sbidoul commented May 10, 2025

Also, please rebase to get a green CI.

@Romathi
Copy link
Author

Romathi commented May 10, 2025

Thanks, good idea! Can you fix the test by updating tests/test_repo/README.md.expected ?

Also, please rebase to get a green CI.

Both are done 👍
Glad you agree with the new icon format — those default avatars were driving me crazy!

[FIX] Unit test for README.md.expected
@sbidoul sbidoul merged commit 168c9e5 into OCA:master May 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants