Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Mar 12, 2025

No description provided.

Copy link

@kanisorn-kate kanisorn-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow
Copy link
Contributor

account_operating_unit is merged. Can you rebase?

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_operating_unit branch 2 times, most recently from 9af5aaa to 41d60ad Compare June 9, 2025 07:59
@BhaveshHeliconia
Copy link
Contributor Author

@AaronHForgeFlow Please review. Thanks

tarteo added a commit to onesteinbv/addons-oca that referenced this pull request Sep 16, 2025
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_operating_unit branch from 41d60ad to 8f0fb86 Compare October 13, 2025 04:25
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_operating_unit branch from 8f0fb86 to 02a0dac Compare October 13, 2025 09:15
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@ByteMeAsap
Copy link
Contributor

@pedrobaeza , can we have this merged?

@pedrobaeza
Copy link
Member

A review from a PSC/maintainer is needed

@AaronHForgeFlow
Copy link
Contributor

/ocabot migration sale_operating_unit

/ocabot rebase

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 9, 2025
@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow The rebase process failed, because command git push --force HeliconiaIO tmp-pr-756:18.0-mig-sale_operating_unit failed with output:

remote: Permission to HeliconiaIO/operating-unit.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/HeliconiaIO/operating-unit/': The requested URL returned error: 403

@AaronHForgeFlow
Copy link
Contributor

Hi @BhaveshHeliconia , could you rebase the branch so runboat becomes available? That would help to review this. Thanks.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_operating_unit branch from 02a0dac to e76ed23 Compare December 9, 2025 09:07
@BhaveshHeliconia
Copy link
Contributor Author

Hi @BhaveshHeliconia , could you rebase the branch so runboat becomes available? That would help to review this. Thanks.

@AaronHForgeFlow : Runboat is available now. Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-756-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9ac01bd into OCA:18.0 Dec 9, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1a230b7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.