fix define for YIELDING #5579
Open
fix define for YIELDING #5579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Alternatively if the intent wasn't to override this, then I can swap the order of the declarations to define the architecture first. |
Collaborator
|
intention is to override, but I haven't checked which of the two is actually preferable on Windows - though I suspect it will be the asm no-op that currently "wins" amid the noisy warning. |
Contributor
Author
|
Alright, can change that. I see past issues now that indicate why it uses the spin lock with nops (#1881 (comment)) |
Collaborator
|
seems to be missing an |
The intent is to define this as nop, but previously it was then immediately overriding it for various architectures, causing a compiler warning on Windows.
Contributor
Author
|
ah, yep, it was missing at the obvious place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent seem to be to define this in one way, but previously it was
then immediately overriding it for various architectures, causing a
compiler warning.