Skip to content

build: Fix LIBNAMESUFFIX handling in CMake documentation #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vtjnash wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −12
Open

build: Fix LIBNAMESUFFIX handling in CMake documentation #5583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Makefile.rule
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
# This library's version
VERSION = 0.3.30.dev

# If you set this prefix, the library name will be lib$(LIBNAMESUFFIX)openblas.a
# and lib$(LIBNAMESUFFIX)openblas.so, with a matching soname in the shared library
#
# If you set this prefix, the library name will be lib$(LIBNAMEPREFIX)openblas.a
# and lib$(LIBNAMEPREFIX)openblas.so, with a matching soname in the shared library
#
# LIBNAMEPREFIX = scipy

# If you set the suffix, the library name will be libopenblas_$(LIBNAMESUFFIX).a
# and libopenblas_$(LIBNAMESUFFIX).so. Meanwhile, the soname in shared library
# is libopenblas_$(LIBNAMESUFFIX).so.0.
# LIBNAMESUFFIX = omp
# If you set the suffix, the library name will be libopenblas$(LIBNAMESUFFIX).a
# and libopenblas$(LIBNAMESUFFIX).so. Meanwhile, the soname in shared library
# is libopenblas$(LIBNAMESUFFIX).so.0.
# LIBNAMESUFFIX = _omp

# You can specify the target architecture, otherwise it's
# automatically detected.
Expand Down
4 changes: 2 additions & 2 deletions cmake/system.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,8 @@ endif()

set(LIBPREFIX "lib${LIBNAMEPREFIX}openblas")

if (DEFINED LIBNAMESUFFIX)
set(LIBPREFIX "${LIBNAMEPREFIX}_${LIBNAMESUFFIX}")
if (DEFINED LIBNAMESUFFIX AND NOT "${LIBNAMESUFFIX}" STREQUAL "")
set(LIBPREFIX "lib${LIBNAMEPREFIX}openblas${LIBNAMESUFFIX}")
endif ()

if (NOT DEFINED SYMBOLPREFIX)
Expand Down
5 changes: 2 additions & 3 deletions docs/build_system.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,8 @@ ensures that there are a sufficient number of buffer sets available.
no symbolic linking to variant names (default is `0`)
- `LIBNAMEPREFIX`: prefix that, if given, will be inserted in the library name
before `openblas` (e.g., `xxx` will result in `libxxxopenblas.so`)
- `LIBNAMESUFFIX`: suffix that, if given, will be inserted in the library name
after `openblas`, separated by an underscore (e.g., `yyy` will result in
`libopenblas_yyy.so`)
- `LIBNAMESUFFIX`: suffix that, if given, will be appended to the library name
after `openblas` (e.g., `_yyy` will result in `libopenblas_yyy.so`)
- `SYMBOLPREFIX`: prefix that, if given, will be added to all symbol names
*and* to the library name
- `SYMBOLSUFFIX`: suffix that, if given, will be added to all symbol names
Expand Down
Loading