Use pyproject.toml and update CLI flag #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the package configuration by migrating from legacy setup.py to pyproject.toml and improves the CLI interface by replacing the confusing --has-index flag with a clearer --no-index flag.
- Migrated from setup.py to pyproject.toml with dynamic versioning
- Replaced legacy script with console entry point
- Changed CLI flag from
--has-indexto--no-indexfor better usability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Removed legacy setup.py configuration file |
| pyproject.toml | Added modern package configuration with dynamic versioning and console entry point |
| scripts/backup_illumina.py | Removed legacy script file |
| seqBackupLib/backup.py | Updated CLI argument from --has-index to --no-index with proper action and help text |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlwith setuptools dynamic version and console entry pointsetup.pyand scripts directory--has-indexwith--no-indexflag in backup CLITesting
black .pytesthttps://chatgpt.com/codex/tasks/task_e_68a60f1b02fc8323ba0e689d7e1bfe2d