Skip to content

Conversation

@davidberenstein1957
Copy link
Member

Description

Add and overview of PR progress to Slack channel

Related Issue

Fixes NA

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

Copy link
Member

@SaboniAmine SaboniAmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! Do we need to activate the Github Action via sponsoring first ?

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

…pruna_internal

- Added new package sources for `fast-hadamard-transform`, `flute-kernel`, `pit`, `pruna`, `pruna-engine`, `pruna-launch-party`, and `pruna-pro`, ensuring they are sourced from `pruna_internal` by default.
- Maintained existing source configurations for `gptqmodel` to handle Apple Silicon Darwin compatibility.
- Removed package sources for `fast-hadamard-transform`, `flute-kernel`, `pit`, `pruna`, `pruna-engine`, `pruna-launch-party`, and `pruna-pro` from `pyproject.toml`, streamlining the configuration.
- Retained the existing source configuration for `stable-fast` and `gptqmodel` to ensure compatibility with `pruna_internal`.
- Cleaned up `pyproject.toml` by removing unnecessary empty lines and ensuring a more streamlined configuration for package sources.
- Maintained existing configurations for `stable-fast` and `gptqmodel` to preserve functionality.
- Adjusted the `default` priority for the `pruna_internal` index to false, ensuring it has the highest priority for package sourcing.
- Set the `default` priority for the `pypi` index to true, making it the lowest priority for package sourcing.
- These changes streamline package resolution and improve dependency management.
- Reverted the `default` priority for the `pruna_internal` index to true, making it the lowest priority for package sourcing.
- Adjusted the `default` priority for the `pypi` index to false, ensuring it has the highest priority for package sourcing.
- These changes enhance package resolution and dependency management.
- Added "N813" to the ignore list for Ruff linting.
- Specified linting rules for "src/pruna/algorithms/base/tags.py" to ignore "E501".
- Introduced new rules for type checking with Ty, allowing for a smoother transition from mypy.
- Updated package versions, including changing "datasets" to ">=0.34" and adding "numpydoc" and "imageio-ffmpeg" to dependencies.
- Bumped project version from 0.2.8 to 0.3.0 for the upcoming release.
@davidberenstein1957
Copy link
Member Author

@SaboniAmine the Slack notification integration requires sponsoring.

Copy link
Contributor

@minettekaum minettekaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants