Skip to content

Conversation

@minettekaum
Copy link
Contributor

Description

The distiller algorithm hyper added to Pruna.

  • The hyper algorithm is in file src/pruna/algorithms/hyper.py
  • The tests are in tests/algorithms/testers/hyper.py
  • distiller, enhancer and recamplertags added to src/pruna/algorithms/base/tags.py
  • PEFT added to pyproject.toml

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

By the tests in tests/algorithms/testers/hyper.py

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

# Default values are chosen based on Table 1 of the FORA paper
return [
Boolean(
"agressive",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Hyperparameter name "agressive" is misspelled

The hyperparameter agressive is misspelled (missing a 'g' - should be aggressive). This is a user-facing configuration parameter that users will need to specify via smash_config["agressive"]. Using a misspelled parameter name in the public API will cause confusion and forces users to use the incorrect spelling. The typo is used consistently throughout the file (lines 132, 137, 143, 148, 154, 158, 164, 168), so it won't cause runtime errors, but it's a poor API design.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants