Update canvas-portal.tsx #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting the cameras `matrixAutoUpdate` and ` matrixWorldAutoUpdate` to `true` in `canvas-portal.tsx` enables object matrices in the `overlay` layer to be computed correctly, allowing compatibility with three.js version 166 and above. *Note:* this has not yet been backward compatibility tested for use with three.js r165
🦋 Changeset detectedLatest commit: 2c94116 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 735e59c:
|
RodrigoHamuy
previously approved these changes
Mar 18, 2025
Owner
|
Haven't had a chance to test, but let's give it a go, will release under |
RodrigoHamuy
approved these changes
Mar 18, 2025
|
Excellent! thanks @RodrigoHamuy there's some significant visual improvements using the latest three.js! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting the cameras
matrixAutoUpdateandmatrixWorldAutoUpdatetotrueincanvas-portal.tsxenables object matrices in theoverlaylayer to be computed correctly, allowing compatibility with three.js version 166 and above.Note: this has not yet been backward compatibility tested for use with three.js r165