Skip to content

Fixed LOB stream multiple callback and deadlock #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
he-is-harry wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed LOB stream multiple callback and deadlock #266

he-is-harry wants to merge 2 commits into from

Conversation

@he-is-harry
Copy link
Contributor

@he-is-harry he-is-harry commented Apr 23, 2025

  • Fixed a bug where a callback could be called multiple times for a write lob request if several streams emitted an error between packet sends
  • Fixed a deadlock which would occur if streams were destroyed before or during a write lob request
    • LOB streams that are closed without an error or end event emitted will now raise an error
  • Added unit and integration tests for these two situations

@he-is-harry
Fixed LOB stream multiple callback and deadlock
254a12d 
- Fixed a situation where a callback could be called multiple times
for a write lob request if several streams emitted an error between
packet sends
- Fixed a deadlock which would occur if streams were destroyed
before or during a write lob request
    - LOB streams that are closed without an error or end event
      emitted will now raise an error
- Added unit and integration tests for these two situations
jeffalbion
jeffalbion approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@jeffalbion jeffalbion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ELA

@he-is-harry
Copy link
Contributor Author

he-is-harry commented Apr 24, 2025

It seems this PR was ELA'd instead of the intended #263. So, I think this PR might still need a non-author code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffalbion jeffalbion jeffalbion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@he-is-harry @jeffalbion