sources/channel: Send Closed for SendSender, not only Sender; fix possible race
#236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
added a commit
to ids1024/smithay
that referenced
this pull request
Dec 17, 2025
`SyncSender` isn't properly sending `Closed`: Smithay/calloop#236 In any case, using `Sender` seems appropriate if we don't need it to be `Sync`.
I believe previous there is a theoretically possible race, since the `.ping()` call would have happened before the `mpsc::Sender` was dropped.
Presumably this should behave like `Sender`, but only ping once all clones have been dropped. This should achieve that.
This seems to be the oldest 14.x image available now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.