-
Notifications
You must be signed in to change notification settings - Fork 58
Add CI #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #74
Conversation
8783b98 to
e452972
Compare
148792b to
0190362
Compare
|
@Drakulix I have rebased this PR. |
No objections at all. Having proper CI and auto-publishing is probably a good idea. |
Drakulix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Two last questions, through...
@Slabity can you setup the CRATES_TOKEN secret?
Alternatively I can do it, if you give me push access to drm-sys as well, otherwise the upload will fail.
| with: | ||
| toolchain: stable | ||
| override: true | ||
| - name: Publish crates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this step deal with the three different packages of the repository?
Or do we need multiple steps here?
The order is important as well, since the crates depend on each other.
We need to push drm-sys first, then drm-ffi and at last drm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step uses publish-crates action which supports publishing workspace members with dependencies.
It works for my projects just a fine. I hope it will also works here.
| - uses: actions-rs/clippy-check@v1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| args: --all --all-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katyo You might want to expand this with --all-targets so that the examples are linted, too.
In other news something odd is going on with the clippy on nightly. The current 1.51 stable gives off extra upper_case_acronyms warnings in src/lib.rs, and tons of redundant_field_names warnings, but nightly doesn't. Is this a temporary fluke or do we need extra configuration? Have you seen this on other projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, these crates are not in a workspace :)
Solution for #73
Implemented tasks:
clippyAll tasks runs on ubuntu 20.04.
System version of DRM headers is used, so bindings may lack some bleeding edge APIs.
To get publishing working you need set
CRATES_TOKENsecret.Currently supported platforms for
bindgen:Needed for gbm.rs#4