-
Notifications
You must be signed in to change notification settings - Fork 232
Updated required .NET to 4.7.2 #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.X
Are you sure you want to change the base?
Conversation
Updated required .NET to 4.7.2
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
WalkthroughDocumentation updated to reflect the .NET target framework version change from 4.6.2 to 4.7.2 in the Requirements section of README.md. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Updated required .NET to 4.7.2
Description
Updated required .NET to 4.7.2, current mentioning of .Net 4.6.2 does not meet the requirements.
Motivation and Context
If this requirement for .NET 4.7.2 is not followed, SharpHound fails with:
"|ERROR|The .Net Runtime is not compatible with SharpHound. Please update to .Net 4.7.2."
How Has This Been Tested?
On a Windows System, Windows Server 2016, with the default .Net 4.6.2.
SharpHound 2.8.0
Exectution fails.
Install .NET to 4.7.2.
Execution works
Screenshots (if appropriate):
Checklist:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.