Adding aria-label and aria-labelledby to PopoverContent #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de1b490 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dancormier
requested changes
Dec 19, 2025
Contributor
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
I think the linting failed because it expects either all quoted prop names or camelCase.
We go with camelCase these prop names across our components, so would you mind removing the quotes @chris-doucette-stack?
Once that change is made, I'm happy to see this merged in 🙂
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
packages/stacks-svelte/src/components/Popover/PopoverContent.svelte
Outdated
Show resolved
Hide resolved
chris-doucette-stack
deleted the
cdoucette/popover-accessibility-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds accessibility props, aria-label and aria-labelledby to the PopoverContent component. I have added tests to ensure the props are added when provided and excluded when not.