Skip to content

Intersection builder #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markspec merged 24 commits into from
Jun 2, 2025
Merged

Intersection builder #162

markspec merged 24 commits into from
Jun 2, 2025

Conversation

@BrianMichell
Copy link
Collaborator

@BrianMichell BrianMichell commented May 22, 2025

This PR enables an MVP for coordinate-based access. This is not feature complete.

Known issues

  • Multiple slices lose all Range Descriptors.
  • Longest-run logic results in incorrect Range Descriptors.
  • Multiple slices do not handle different dimensions properly (dimensions will be dropped).
  • Appropriate unit tests do not exist.

Deferred work and features

  • Multiple sorts untested.
  • Full caching logic for all data.
  • Implementation for list and range descriptor slicing.
  • Full type-agnostic internals.
  • Internal refactoring.

BrianMichell added 23 commits May 14, 2025 15:29
@BrianMichell
Begin work on coordinate-based intersection builder
4ce9c35
@BrianMichell
Enhance slicing logic and flexibility
f3f325f
@BrianMichell
Fix elements getting dropped from slice operation
535f7d1
@BrianMichell
Compilable version -- Runtime issues
2f6e23f
@BrianMichell
Checkpoint
74c334e
@BrianMichell
Working one-slice-one-sort
83ea50a
@BrianMichell
Split sorter and getter
e9c1771
@BrianMichell
Begin modularizing
0c3c2e2
@BrianMichell
Cleanup old code
364b9ed
@BrianMichell
Solicit entire read before building vector
0126032
@BrianMichell
Begin prep for final API
dcdd41d
@BrianMichell
Fix coordinate selector internal import
5d77a9e
@BrianMichell
Add warning
a6908cd
@BrianMichell
Add a composible "read" function
b2b5fdc
@BrianMichell
Begin formatting
26b2a3c
@BrianMichell
Resolve off-by-one error in run builder
9f03ca8
@BrianMichell
clang-formatting
e269281
@BrianMichell
Linting
2ef5f9c
@BrianMichell
Fix test build
d2a6264
@BrianMichell
Run coordinate selector tests
35975d7
@BrianMichell
Remove const qualifier for dataset
0dcd219
@BrianMichell
Update API to read multiple Variables
2f2eb4b
@BrianMichell
Begin type erasure and local caching optimizations
901d328
@BrianMichell BrianMichell requested a review from markspec May 22, 2025 15:43
@BrianMichell BrianMichell added the enhancement New feature or request label May 22, 2025
markspec
markspec approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@markspec markspec merged commit ba18d0f into main Jun 2, 2025
6 checks passed
@markspec markspec deleted the intersection_builder branch June 2, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markspec markspec markspec approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrianMichell @markspec