Skip to content

Conversation

@jplatte
Copy link

@jplatte jplatte commented Oct 5, 2023

You didn't declare an MSRV, so publishing a new version with this in as a patch release should be fine.

cc bkchr/proc-macro-crate#39

@TOETOE55
Copy link
Owner

TOETOE55 commented Oct 5, 2023

I will upgrade the syn to 2.0 and then publish a new version. Maybe I would add some check on CI and rewrite unit tests if I have time.

@jplatte
Copy link
Author

jplatte commented Oct 5, 2023

Oh, somehow I missed that syn is also due for an upgrade (not at 2.0 yet here) 😄

@jplatte
Copy link
Author

jplatte commented Dec 28, 2023

Hey @TOETOE55, any reason this PR isn't merged? Do you need help with the syn upgrade?

@TOETOE55
Copy link
Owner

TOETOE55 commented Dec 28, 2023

Hey @TOETOE55, any reason this PR isn't merged? Do you need help with the syn upgrade?

#5 Here are some of the status quo of cfg-vis, some issues have not been thought through, so you have been shelving your PR.

(On the other hand, I may not have much energy or time to work on open source projects for the next year or two.)

@jplatte
Copy link
Author

jplatte commented Dec 28, 2023

Thanks for the update! I'm not super happy with having conditionally-public items anyways, so maybe I'll try to remove the cfg-vis use altogether.

@TOETOE55
Copy link
Owner

Thanks for the update! I'm not super happy with having conditionally-public items anyways, so maybe I'll try to remove the cfg-vis use altogether.

I'm sorry~. I'll also try to find out if anyone can help.

@jplatte
Copy link
Author

jplatte commented Dec 28, 2023

No worries, you don't owe me or the other users of the library anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants