WIP: Group heirarchy #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
InverseSemigroupaboveGroup, andRegularSemigroupabove that.There are a few things that I think need resolving before this gets merged:
Group? The main one I was toying with was (borrowing some bits fromsemialign):And then using this to compute diffs. But it didn't pay out into anything ergonomic. I probably need to think more about whether this should be done with
ZiporSemialign.Ed mentioned:
(Did this pay out?)
Should the inverse operation be called
inv, or something else? (Bikeshedding)If pseudoinverses in
RegularSemigroupare not unique, should there be a functioninvs :: g -> NonEmpty g, with no guarantee that it returns every pseudoinverse (too expensive to calculate otherwise)?Where should
powsit in the hierarchy? If you have unique inverses (InverseSemigroup) you can compute sensiblepowfor any nonzero integer power, but zero would have to bex <> inv xorinv x <> x, and I don't think you have a guarantee that those are the same.