perf(audio): optimize AudioManager::addAudioEvent #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
reviewed
Nov 13, 2025
xezon
reviewed
Nov 29, 2025
…y early and avoiding string allocations
bobtista
force-pushed
the
bobtista/optimize-add-audio-event
branch
from
c8831a0 to
2f03ad8
Compare
…k now that init order is fixed
bobtista
force-pushed
the
bobtista/optimize-add-audio-event
branch
from
2f03ad8 to
b42cc31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes AudioManager::addAudioEvent() to avoid wasted allocations and computations for sounds that won't play locally.
Changes: