-
Notifications
You must be signed in to change notification settings - Fork 4
refs #42208 #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refs #42208 #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment below...
| return isIndividual(node) ? node.wdkReference.help | ||
| return isIndividual(node) ? node.wdkReference.description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why we were returning help here? Was there a good reason for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that it has to do with the current implementation of getTooltipContent - in that function, we seem to be delegating to getDescription when the node either (1) isn't an individual or (2) doesn't have a "search" property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. I think it also has to do with the fact that AttributeField doesn't have a description property. I think we might need to have some branching logic based on the type of wdkReference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the help is for attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary for questions.... for questions we would not want to deal with description...
No description provided.