[ xdebug ] Add --experimental-unsafe-ide-integration option in PHP.wasm CLI
#2947
+627
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mho22
added
[Type] Enhancement
This was referenced Nov 26, 2025
adamziel
reviewed
Nov 27, 2025
mho22
force-pushed
the
add-xdebug-path-mappings-in-php-wasm-cli
branch
from
bfe7f30 to
2235e13
Compare
Collaborator
Author
|
@adamziel I created a new package named |
adamziel
reviewed
Dec 5, 2025
| }); | ||
|
|
||
| it('should not duplicate configuration if it already exists', () => { | ||
| const json = '{\n "configurations": []\n}'; |
Collaborator
There was a problem hiding this comment.
tangential and unrelated to this PR, but a test where json is just {} would be useful. Similarly, a test where it's an unexpected value such as "" or {}
adamziel
reviewed
Dec 5, 2025
| "author": "The WordPress contributors", | ||
| "contributors": [ | ||
| { | ||
| "name": "Adam Zielinski", |
Collaborator
There was a problem hiding this comment.
We're long past the point where it's just me. Let's just remove the contributors key entirely, "author" will do.
adamziel
reviewed
Dec 5, 2025
| @@ -0,0 +1,46 @@ | |||
| { | |||
| "name": "@php-wasm/cli-util", | |||
Collaborator
There was a problem hiding this comment.
nitpick:
Suggested change
| "name": "@php-wasm/cli-util", | |
| "name": "@php-wasm/cli-utils", |
adamziel
approved these changes
Dec 5, 2025
Collaborator
adamziel
left a comment
adamziel
left a comment
There was a problem hiding this comment.
I've left a few nitpicks but it's solid otherwise. Feel free to merge after addressing them. Thank you! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Based on issue #2763 and following pull request #2777
This pull request generates the IDE configuration files inside the developer's IDE.
Implementation details
It first clears all the configs named
PHP.wasm CLI - Listen for Xdebugin VSCode and PHPStorm config files.If
--xdebugand--experimental-unsafe-ide-integrationoptions are present, we add IDE configs in the related configs.PHPStorm : it adds a new
serverwith namePHP.wasm CLI - Listen for Xdebugin.idea/workspace.xml.VSCode : it adds a new
configurationwith namePHP.wasm CLI - Listen for Xdebugin.vscode/launch.json.Correction of an error in Playground CLI console.logs.
Creation of a new distinct package named
@php-wasm/cli-utilwhich is integrated into PHP.wasm CLI and Playground CLI with thexdebug-path-mappings.Next steps are reported in the Xdebug Follow-up issue.
Testing Instructions (or ideally a Blueprint)
CI
🧪 test-php-wasm-cli-util
cc @fellyph