Skip to content

Conversation

@teor2345
Copy link
Contributor

Motivation

As part of #2480, we want to document how Zebra enforces the consensus rules for version group IDs.

This PR closes #2480, once PR #2679 merges as well.

Review

@conradoplg can review this PR.

Reviewer Checklist

  • Consensus rules are implemented as documented

@teor2345 teor2345 added A-docs Area: Documentation A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement P-Low labels Aug 31, 2021
@teor2345 teor2345 requested a review from conradoplg August 31, 2021 23:07
@teor2345 teor2345 self-assigned this Aug 31, 2021
@conradoplg conradoplg enabled auto-merge (squash) September 1, 2021 17:05
@conradoplg conradoplg merged commit dcc0dcd into main Sep 1, 2021
@conradoplg conradoplg deleted the version-group-id-doc branch September 1, 2021 17:44
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-consensus Area: Consensus rule updates A-docs Area: Documentation C-enhancement Category: This is an improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: V5 Transaction's network upgrade is not verified before calculating the SigHash

4 participants