Skip to content

Conversation

@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 20, 2022

Motivation

Once we merge PRs #4637 and #4640, this job will be redundant.
Depends-On: #4637

Review

Anyone can review this low priority PR.

Reviewer Checklist

  • Job is gone

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low ❄️ labels Jun 20, 2022
@teor2345 teor2345 requested a review from a team as a code owner June 20, 2022 23:39
@teor2345 teor2345 self-assigned this Jun 20, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 20, 2022 23:39
@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

update

✅ Branch has been successfully updated

@gustavovalverde gustavovalverde enabled auto-merge (squash) June 21, 2022 10:59
@gustavovalverde gustavovalverde disabled auto-merge June 21, 2022 11:00
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dconnolly
dconnolly previously approved these changes Jun 22, 2022
@teor2345
Copy link
Contributor Author

This will probably have merge conflicts with PR #4637, feel free to fix them.
(Just two jobs deleted next to each other.)

@gustavovalverde gustavovalverde dismissed stale reviews from dconnolly and themself via 43a4b69 June 22, 2022 10:51
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after solved merge conflict

@mergify mergify bot merged commit 257f017 into main Jun 22, 2022
@mergify mergify bot deleted the remove-redundant-job branch June 22, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants