images/windows/toolsets: add NFS-Client optional feature #13388
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People wanting to use GitHub-hosted Windows runners with a [gomodfs](https://github.com/tailscale/gomodfs/) NFS server need the Windows NFS client, but that takes 3 minutes to install in every run. This pre-installs it, to save each build 3 minutes later. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the Windows NFS-Client feature to all three Windows Server runner images (2019, 2022, and 2025) to avoid the 3-minute installation overhead in each workflow run when users need NFS functionality for scenarios like using gomodfs NFS servers.
Key Changes
- Adds NFS-Client to the windowsFeatures array in toolset-2019.json, toolset-2022.json, and toolset-2025.json
- Uses
"includeAllSubFeatures": trueflag consistent with other Windows Server features - Pre-installs the feature during image build time, eliminating runtime installation delays
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| images/windows/toolsets/toolset-2025.json | Adds NFS-Client feature with includeAllSubFeatures flag to Windows Server 2025 configuration |
| images/windows/toolsets/toolset-2022.json | Adds NFS-Client feature with includeAllSubFeatures flag to Windows Server 2022 configuration |
| images/windows/toolsets/toolset-2019.json | Adds NFS-Client feature with includeAllSubFeatures flag to Windows Server 2019 configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People wanting to use GitHub-hosted Windows runners with a gomodfs NFS server need the Windows NFS client, but that takes 3 minutes to install in every run.
This pre-installs it, to save each build 3 minutes later.
Related issue:
Check list