chore(dev): deploy binary distributions to PyPI #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also slightly updated the CI workflows.
2bndy5
added a commit
to 2bndy5/circuitpython-build-tools
that referenced
this pull request
Nov 27, 2025
This removes the "Build Python package" step from the "Build CI" workflow in favor of reusing the build job in the release CI workflow. It builds off the changes in adafruit#135 by adding more triggers to the release CI. I also removed some steps in the Build CI workflow that would only make sense if experimenting with GitHub Actions.
This was referenced Nov 27, 2025
tannewt
approved these changes
Dec 3, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thank you! I added the trusted publisher as well.
Contributor
Author
Oh in that case, I would have used pypa/gh-action-pypi-publish to upload dists to PyPI (without using an API token). |
2bndy5
added a commit
to 2bndy5/circuitpython-build-tools
that referenced
this pull request
Dec 3, 2025
This removes the "Build Python package" step from the "Build CI" workflow in favor of reusing the build job in the release CI workflow. It builds off the changes in adafruit#135 by adding more triggers to the release CI. I also removed some steps in the Build CI workflow that would only make sense if experimenting with GitHub Actions. This also uploads dists to PyPI using the trusted publisher setup in the PyPI project settings.
2bndy5
added a commit
to 2bndy5/circuitpython-build-tools
that referenced
this pull request
Dec 3, 2025
This removes the "Build Python package" step from the "Build CI" workflow in favor of reusing the build job in the release CI workflow. It adds triggers to the release CI for `push` and `pull_request` events that target the main branch. To be clear, publishing will only happen when a GitHub release is published (just like previous behavior). I also removed some steps in the Build CI workflow that would only make sense if experimenting with GitHub Actions. This patch uploads dists to PyPI using the trusted publisher setup in the PyPI project settings. (per adafruit#135 (review))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- quoted from #133
I also slightly updated the CI workflows.