CASSANDRA-20820 Include Level information for UnifiedCompactionStrategy in nodetool tablestats output #4476
+504
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Looks good, I have a few suggestions to reduce code redundancy.
test/distributed/org/apache/cassandra/distributed/test/ColumnFamilyStoreMBeansTest.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.java
Show resolved
Hide resolved
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsPrinter.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/ColumnFamilyStoreMBeansTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/ColumnFamilyStoreMBeansTest.java
Outdated
Show resolved
Hide resolved
| CLUSTER.get(1).runOnInstance(() -> { | ||
| ColumnFamilyStore cfs = Keyspace.open(KEYSPACE).getColumnFamilyStore("cf"); | ||
| Assert.assertTrue(cfs.getPerLevelMaxDensityThreshold().length > 0); | ||
| }); |
Contributor
There was a problem hiding this comment.
can you add actual threshold value validation?
Contributor
Author
There was a problem hiding this comment.
My understanding is that the max density threshold in UCS is calculated dynamically based on some runtime values double maxDensity = controller.getMaxLevelDensity(0, controller.getBaseSstableSize(controller.getFanout(0)) / shardManager.localSpaceCoverage());. I think if I were to calculate and check that the two values correspond I would end up doing something similar to what is done in getPerLevelMaxDensityThreshold.
test/distributed/org/apache/cassandra/distributed/test/ColumnFamilyStoreMBeansTest.java
Show resolved
Hide resolved
jyothsnakonisa
approved these changes
Dec 19, 2025
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Thanks for addressing all the feedback, looks good to me
krummas
reviewed
Dec 19, 2025
src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional level information to table stats for UCS.
patch by Alan Wang;
reviewed by for CASSANDRA-20820
Co-authored-by: Name1
Co-authored-by: Name2