HIVE-29381: Iceberg: [V3] SHOW/DESCRIBE table should show the actual data type #6243
+141
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests passed
tests pending
tests unstable
labels
| } | ||
|
|
||
| private boolean isOverriddenColumn(Type.TypeID typeID) { | ||
| // Geometry, Geography & Timestamp_ns types |
Contributor
There was a problem hiding this comment.
You'll be adding TIMESTAMP_NANO here post #6242 , is my understanding correct?
Contributor
|
LGTM +1 (non-binding) Verified changes in local setup as well AFTER: |
Aggarwal-Raghav
approved these changes
Dec 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Show the actual data type which was used for creating the table for V3 columns, instead of the inner implementation
Why are the changes needed?
Better usability
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT