Skip to content

Deflake RouteSegmentedConnPool slow disposal timing #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturobernalg merged 1 commit into from
Dec 18, 2025
Merged

Deflake RouteSegmentedConnPool slow disposal timing #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions httpcore5/src/test/java/org/apache/hc/core5/pool/FakeConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.locks.LockSupport;

import org.apache.hc.core5.io.CloseMode;
import org.apache.hc.core5.io.ModalCloseable;
Expand All @@ -49,11 +50,7 @@ final class FakeConnection implements ModalCloseable {
@Override
public void close(final CloseMode closeMode) {
if (closeSleepMs > 0) {
try {
Thread.sleep(closeSleepMs);
} catch (final InterruptedException ignore) {
Thread.currentThread().interrupt();
}
sleepAtLeastMillis(closeSleepMs);
}
closes.incrementAndGet();
closedLatch.countDown();
Expand All @@ -71,4 +68,22 @@ int closeCount() {
boolean awaitClosed(final long ms) throws InterruptedException {
return closedLatch.await(ms, TimeUnit.MILLISECONDS);
}

private static void sleepAtLeastMillis(final long millis) {
final long deadline = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(millis);
boolean interrupted = false;
for (; ; ) {
final long remaining = deadline - System.nanoTime();
if (remaining <= 0) {
break;
}
LockSupport.parkNanos(remaining);
if (Thread.interrupted()) {
interrupted = true;
}
}
if (interrupted) {
Thread.currentThread().interrupt();
}
}
}